Qt-ifying

[psomers3]

@jakobhampel
Another example spot to make things more QT-like is to not use a function like this and instead replace it with a set of signal-slots such as "label changed" or "item added", etc coming from the database.

[jakobhampel]

@psomers3 I don't quite get it. So instead of using this function, I send a signal coming from the database every time a user changes something? And this signal I would use to... set a boolean hasChanged in the image_display to True (for example)?

[psomers3]

@jakobhampel Yes to the first question, but it can also have different signals depending on what is changed. Yes to the second question, but I also haven't seen how often/where exactly you use this function so it may not be super critical, but once you're passing lists of data around, I would think first if you have to do it that way.

[jakobhampel]

@psomers3 could I also do it this way:
Evertime a user does anything significant in the image, automatically assume something has changed (and ask for saving when user wants to quit/change file)

Pro: No calls to the database needed, very simple (f.e. a class variable in the image_display to keep track of it)
Cons: When user effectively does not change anything (f.e. adding a shape, then removing it again) it will assume something has changed nevertheless. I think this is ok, I often see this behavior in other softwares (Word, etc.).

[psomers3]

@jakobhampel I am fine with that idea. We will need something that does more isolated change tracking and this could make it easier to do in the long run. So I would create something that describes what the change was and is emitted with the signal. i.e. a dataclass or something with different info like file changed, type of change (label move, label creation, etc).