Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on hmmlearn in favour of pomegranate #218

Open
hardingnj opened this issue Nov 7, 2018 · 2 comments · May be fixed by #264
Open

Remove dependency on hmmlearn in favour of pomegranate #218

hardingnj opened this issue Nov 7, 2018 · 2 comments · May be fixed by #264
Assignees
@hardingnj
Milestone
1.3

Comments

@hardingnj
Copy link
Collaborator

Following #188 we have a dependency on pomegranate.

However, we also depend on hmmlearn for the non poission ROH code. To reduce overall number of dependencies hmmlean should be removed for pomegranate here.
@alimanfoo alimanfoo added this to the 1.3 milestone Dec 22, 2018
@alimanfoo
Copy link
Contributor

alimanfoo commented Jan 11, 2019 via email

@hardingnj
Copy link
Collaborator Author

Cool- I'll nudge this up the priority list!

@hardingnj hardingnj self-assigned this Jan 11, 2019
@hardingnj hardingnj linked a pull request May 14, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hardingnj hardingnj

Labels
None yet
Projects
None yet
Milestone
1.3
Development

Successfully merging a pull request may close this issue.

removal of hmmlearn in favour of pomegranate hardingnj/scikit-allel
2 participants
@alimanfoo @hardingnj