Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzz Testing #97

Closed
wants to merge 2 commits into from
Closed

Conversation

distractedm1nd
Copy link
Collaborator

@distractedm1nd distractedm1nd commented Jun 22, 2022

Opening this as a draft PR, because I only added one fuzz test so we can get an idea of what it would look like before writing more. Closes #68.

I also exported ds.Flattened, since it is a useful data structure to have (for example as input to ImportExtendedDataSquare)

The two tests that were previously in this package are now implemented as subtests. When not running with -fuzz, they run with the original inputs provided in the f.Add call.

I removed the second half of theTestEdsRepairTwice test - since I assume the purpose is to test if the correct error is thrown when there are too many erasures. The case it tests for after repair is covered in the MaximumErasures subtest anyways. Or am I missing something?

Copy link
Member

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also exported ds.Flattened

This warrants its own PR and discussion, please revert so as not to pollute this one.

CI is failing.

@distractedm1nd
Copy link
Collaborator Author

@adlerjohn Yeah was debating that myself as well - makes sense, will do.

Btw, I believe the CI is failing because native go fuzzing is only supported since 1.18

@evan-forbes
Copy link
Member

evan-forbes commented Jun 24, 2022

yeah, we'll have to update everything to use go 1.18 if we want to use the new fuzzer. we should do this in other repos as well, but it should be done in a separate PR imo.

it should also be investigated to make sure that updating here won't effect repos that import this library, as we don't want to update tendermint or the cosmos-sdk until the core team does

@adlerjohn
Copy link
Member

Agree, unless and until we want all downstream dependencies to require Go 1.18, we should hold off on this. Unless as you said, you can use a Go 1.18 module in a Go 1.17 project without issue.

@liamsi
Copy link
Member

liamsi commented Oct 26, 2022

Can we close this one until we continue working on it?

@liamsi
Copy link
Member

liamsi commented Oct 26, 2022

Closing as discussed

@liamsi liamsi closed this Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add fuzzing tests
4 participants