Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set expiration date in the timeout-handler instead of an sleep #367

Open
Tracked by #486
tty47 opened this issue May 23, 2024 · 1 comment · May be fixed by #599
Open
Tracked by #486

Set expiration date in the timeout-handler instead of an sleep #367

tty47 opened this issue May 23, 2024 · 1 comment · May be fixed by #599
Assignees
@mojtaba-esk @tty47
Labels
enhancement New feature or request knuu
Milestone
v0.17.0 Long Runn...

Comments

@tty47
Copy link
Contributor

tty47 commented May 23, 2024

update this command:

knuu/pkg/knuu/knuu.go

Line 229 in 2c3edce

commands = append(commands, fmt.Sprintf("sleep %d", int64(timeout.Seconds())))

to an expiration date
@tty47 tty47 self-assigned this May 23, 2024
@tty47 tty47 added the knuu label May 23, 2024
@smuu smuu added bug Something isn't working enhancement New feature or request labels Jul 4, 2024
@smuu smuu mentioned this issue Jul 5, 2024
Open
@smuu smuu removed the bug Something isn't working label Jul 5, 2024
@smuu smuu mentioned this issue Jul 5, 2024
Open
@mojtaba-esk
Copy link
Member

if the handler at some point restarts, the timeout also resets so it is more reliable to have a fixed date/time.

@mojtaba-esk mojtaba-esk self-assigned this Dec 19, 2024
@mojtaba-esk mojtaba-esk linked a pull request Dec 19, 2024 that will close this issue
Open
@mojtaba-esk mojtaba-esk moved this from Todo to Blocked in Celestia DevOps/Testing Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojtaba-esk mojtaba-esk

@tty47 tty47

Labels
enhancement New feature or request knuu
Projects
None yet
Milestone
v0.17.0 Long Running Networks
Development

Successfully merging a pull request may close this issue.

feat: add deadline instead of timeout celestiaorg/knuu
3 participants
@mojtaba-esk @smuu @tty47