Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible breaking changes needed for v1.0.0 #97

Open
3 of 4 tasks
ManonMarchand opened this issue Mar 8, 2023 · 6 comments
Open
3 of 4 tasks

Possible breaking changes needed for v1.0.0 #97

ManonMarchand opened this issue Mar 8, 2023 · 6 comments
Assignees
Milestone

Comments

@ManonMarchand
Copy link
Member

ManonMarchand commented Mar 8, 2023

@ManonMarchand ManonMarchand added this to the 1.0.0 milestone Mar 8, 2023
@ManonMarchand

This comment was marked as outdated.

@fxpineau
Copy link
Member

Since MOCPy has been partly developed on European projects (@bmatthieu3 ?) and relies on MOC Lib Rust which has also been partly developed on the ESCAPE European projects, (another one before @bmatthieu3 ?), we probably should add an Acknowledgements section.

For ESCAPE it would be (see MOC Lib Rust):

This work has been partly supported by the ESCAPE project.  
ESCAPE - The **E**uropean **S**cience **C**luster of **A**stronomy & **P**article Physics **E**SFRI Research Infrastructures -
has received funding from the **European Union’s Horizon 2020** research and innovation programme under **Grant Agreement no. 824064**. 

@ManonMarchand
Copy link
Member Author

Citations infos ?

@ManonMarchand ManonMarchand changed the title Sections we'll want in the README for v1.0.0 Possible breaking changes needed for v1.0.0 Jul 10, 2024
@ManonMarchand
Copy link
Member Author

To be discussed:

  • order of a moc is called depth, max_depth, max_order, order or max_norder (and there is also nside) depending of the method. This is nightmare-ish.

@tboch
Copy link
Collaborator

tboch commented Jul 10, 2024

My suggestion: stick to the vocabulary of the MOC standard (ie order). MOCLibRust has introduced depth which is used nowhere else to my knowledge.

@fxpineau
Copy link
Member

fxpineau commented Jul 10, 2024

depth is a very common term in generic tree data structures, see e.g here, or this O'Mullane paper.
I introduced it when I was working on abstract quad-tree indexation schemes (possibly implemented by HTM, HEALPix, HEAZIP I thought I invented but that was already existing (I do not remember the original name: depht 0 cells are made of 3 depth 1 zones + an upper triangle, at depth 2 each zone is then defided into 4 sub-zones while the upper triangle is divided into 3 sub-zones + an upper triangle, and so on), ...).
But I agree that the common term in the HEALPix ecosystem is order probably since the NESTED indexation scheme is based on the Z-order curve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants