Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should FM result set be in a weak set, so it can close when outside of scope? #441

Open
ccgus opened this issue Nov 30, 2015 · 1 comment
Open

Should FM result set be in a weak set, so it can close when outside of scope? #441

ccgus opened this issue Nov 30, 2015 · 1 comment
Milestone
3.0

Comments

@ccgus
Copy link
Owner

ccgus commented Nov 30, 2015

See this twitter thread for info:
https://twitter.com/ccgus/status/671395172375105536

Basically- if an FMResultSet goes out of scope, it'll stay in a set forever. Should it have a weak ref somewhere, so it can be dealloc'd and clean up on its own?
@ccgus ccgus added this to the 3.0 milestone Nov 30, 2015
@akshaynhegde
Copy link

Looks like there is a pull request related to this.
#304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
2 participants
@ccgus @akshaynhegde