Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove json schema validation from interfaces and converters #1166

Open
h-mayorquin opened this issue Dec 19, 2024 · 0 comments · May be fixed by #1168
Open

Remove json schema validation from interfaces and converters #1166

h-mayorquin opened this issue Dec 19, 2024 · 0 comments · May be fixed by #1168
Assignees
@h-mayorquin
Labels
refactor

Comments

@h-mayorquin
Copy link
Collaborator

After #1022 we now have a pedantic validate_call in most cases and the current method is more problematic.

See the discussion here #1157 (comment) for background but basically from #1157 the current mechanism should be constrained to use cases like the NWBGUIDE and actual source validation is to be the responsibility of Pydantic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@h-mayorquin h-mayorquin

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove source validation from converters and interfaces catalystneuro/neuroconv
1 participant
@h-mayorquin