Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SourceDocument should provide method for vector #2661

Open
lintool opened this issue Dec 17, 2024 · 0 comments
Open

SourceDocument should provide method for vector #2661

lintool opened this issue Dec 17, 2024 · 0 comments

Comments

@lintool
Copy link
Member

lintool commented Dec 17, 2024

Currently, SourceDocument only provides contents() which returns a String.

This means that for dense vectors, we first convert into a string and then parse back into a vector... which is silly.

We should add something like

float[] vector();
vincent-4 pushed a commit to vincent-4/anserini that referenced this issue Dec 25, 2024
…method with default null implementation - Update vector document generators to use vector() with string fallback - Addresses inefficient vector-to-string conversion pattern - See: castorini#2661
vincent-4 pushed a commit to vincent-4/anserini that referenced this issue Dec 25, 2024
…method with default null implementation - Update vector document generators to use vector() with string fallback - Addresses inefficient vector-to-string conversion pattern - See: castorini#2661
vincent-4 pushed a commit to vincent-4/anserini that referenced this issue Dec 25, 2024
…method with default null implementation - Update vector document generators to use vector() with string fallback - Addresses inefficient vector-to-string conversion pattern - See: castorini#2661
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant