Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParquetDenseVectorCollection reads all records in memory before processing... #2654

Open
lintool opened this issue Dec 15, 2024 · 0 comments

Comments

@lintool
Copy link
Member

lintool commented Dec 15, 2024

This leads to unnecessarily high memory consumption.

At https://github.com/castorini/anserini/blob/master/src/main/java/io/anserini/collection/ParquetDenseVectorCollection.java#L124 -we can see that the initializeParquetReader method reads all records into memory. It shouldn't do that. Instead, the class should be incrementally pulling records when readNext() is called...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant