Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add casbin-cpp to vcpkg #217

Open
shishirong opened this issue Nov 25, 2022 · 7 comments
Open

Add casbin-cpp to vcpkg #217

shishirong opened this issue Nov 25, 2022 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@shishirong
Copy link

Description

I issued in vcpkg,but closed by someone.
Have a expert to reopen or Pull requests about casbin-cpp.

@casbin-bot
Copy link
Member

@casbin-bot casbin-bot added the enhancement New feature or request label Nov 25, 2022
@PokIsemaine
Copy link
Member

I try again microsoft/vcpkg#28976

@nomeguy
Copy link

nomeguy commented Jan 30, 2023

see: microsoft/vcpkg#29027

@PokIsemaine
Copy link
Member

The issue was closed again, it looks like the way casbin-cpp is installed by CMake is causing some difficulty adding to vcpkg. Can anyone fix this problem and open this issue again?

@BillyONeal
Copy link

To clarify, we didn't identify a specific problem with what casbin-cpp does; only that the generated instructions did not appear to match the user instructions in https://github.com/casbin/casbin-cpp which meant that the supplied portfile.cmake didn't install the right bits for users to use.

The author of that PR, @ex-purple said:

I figured out what's wrong Library and CMake configuration are installed in the CMake User Package Registry.

I don't know what "CMake User Package Registry" means; it certainly isn't a thing understood by vcpkg. The port just needs to install the right configs or similar to ${CURRENT_PACKAGES_DIR}/share/${PORT} so that find_package works for downstream customers.

@ex-purple
Copy link

Look here
System installation (install command) is present only for headers. Library and cmake configuration are exported to the CMake User Package Registry.

CMake User Package Registry it is user specific installation. vcpkg works with system installation, so we have only headers for the vcpkg port

@PokIsemaine
Copy link
Member

@ex-purple Thanks for your help, I would like to see if casbin-cpp needs to be changed to make it successfully added to vcpkg. If necessary, you can consider submitting a PR to casbin-cpp, which is grateful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants