Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOMParser does not recognise BODY and thus creates it twice #1615

Open
OlaviSau opened this issue Nov 18, 2024 · 1 comment · May be fixed by #1617
Open

DOMParser does not recognise BODY and thus creates it twice #1615

OlaviSau opened this issue Nov 18, 2024 · 1 comment · May be fixed by #1617
Labels
bug Something isn't working

Comments

@OlaviSau
Copy link
Contributor

OlaviSau commented Nov 18, 2024 •
edited
Loading

Describe the bug
DOMParser is not compliant with the browser implementation. This breaks frameworks like Angular from setting the innerHTML as an attribute, breaking most renders using Angular.
This occurs because BODY is not recognised and this causes body to be created as an extra element in HappyDOM.

To Reproduce
(new window.DOMParser()).parseFromString("<body><x></x>Example Text", "text/html").body.innerHTML
HappyDOM: <body><x></x>Example Text</body>
Expected behavior
Chrome: <x></x>Example Text

Additional context
tagName BODY should not be created as a standard node.

happy-dom/packages/happy-dom/src/dom-parser/DOMParser.ts

Line 79 in afd256b

const bodyElement = newDocument.createElement('body');

happy-dom/packages/happy-dom/src/dom-parser/DOMParser.ts

Line 87 in afd256b

bodyElement.appendChild(root[PropertySymbol.nodeArray][0]);

@capricorn86
@OlaviSau OlaviSau added the bug Something isn't working label Nov 18, 2024
@OlaviSau OlaviSau changed the title DOMParser does not recognise body as a valid root node DOMParser does not recognise body Nov 18, 2024
@OlaviSau OlaviSau changed the title DOMParser does not recognise body DOMParser does not recognise BODY thus creating it twice Nov 18, 2024
OlaviSau added a commit to OlaviSau/happy-dom that referenced this issue Nov 18, 2024
@OlaviSau
fix: [capricorn86#1615] DOMParser creating body twice
982b0f1
OlaviSau added a commit to OlaviSau/happy-dom that referenced this issue Nov 18, 2024
@OlaviSau
fix: [capricorn86#1615] DOMParser creating body twice
15e6d75
@OlaviSau
Copy link
Contributor Author

OlaviSau commented Nov 18, 2024 •
edited
Loading

@capricorn86 I have created a naive fix for this, I did not handle all the cases - like what happens if there are multiple body elements as siblings / children of body and such. These cases will still fail and would need some rework on how HappyDOM appends / parses the html.

The sibling case could be handled by adding the following to the appendChild part of DOMParser, but that wouldn't solve the child case so perhaps it's better to do it in the XMLParser, but at that point it's not an XMLParser, but instead an HTMLParser as XML does not specify that it should not have multiple BODY tags.
It should not be handled in appendChild as browsers allow appending multiple BODY tags into the html. Thus it is a bit complicated to solve in a way that doesn't compromise on performance and still remains correct.

If performance is not a concern then a naive solution could walk through the output of XMLParser root document tree and remove every child with the tagName body.
If performance is a concern then either a HTMLParser could be created that ignores secondary body tags or a specification option could be added to the XMLParser. Personally I think creating an HTMLParser would make more sense since browsers implement many optimisations and odd rules for parsing HTML.

if (root[PropertySymbol.nodeArray][0]['tagName'] === "BODY") {
	root.removeChild(root[PropertySymbol.nodeArray][0]);
	continue;
}

#1616

@OlaviSau OlaviSau changed the title DOMParser does not recognise BODY thus creating it twice DOMParser does not recognise BODY thus creates it twice Nov 18, 2024
@OlaviSau OlaviSau changed the title DOMParser does not recognise BODY thus creates it twice DOMParser does not recognise BODY and thus creates it twice Nov 18, 2024
capricorn86 added a commit that referenced this issue Nov 19, 2024
@capricorn86
fix: [#1615] Fixes problems related to parsing <html>, <head> and <bo…
25053c8 
…dy> using DOMParser
@capricorn86 capricorn86 linked a pull request Nov 19, 2024 that will close this issue
fix: [#1615] Fixes problems related to parsing <html>, <head> and <body> using DOMParser #1617
Open
capricorn86 added a commit that referenced this issue Nov 19, 2024
@capricorn86
chore: [#1615] Fixes problems related to parsing <html>, <head> and <…
1fb5412 
…body> using DOMParser
capricorn86 added a commit that referenced this issue Nov 28, 2024
@capricorn86
chore: [#1615] Continues on implementation
7e84f3b
capricorn86 added a commit that referenced this issue Nov 29, 2024
@capricorn86
chore: [#1615] Continues on implementation
02c065c
capricorn86 added a commit that referenced this issue Nov 29, 2024
@capricorn86
chore: [#1615] Continues on implementation
38b62c6
capricorn86 added a commit that referenced this issue Nov 29, 2024
@capricorn86
chore: [#1615] Continues on implementation
62dc2f2
capricorn86 added a commit that referenced this issue Nov 29, 2024
@capricorn86
chore: [#1615] Continues on implementation
88cd748
capricorn86 added a commit that referenced this issue Dec 4, 2024
@capricorn86
chore: [#1615] Continues on implementation
3c6ce0e
capricorn86 added a commit that referenced this issue Dec 7, 2024
@capricorn86
chore: [#1615] Continues on implementation
b5d0b2e
capricorn86 added a commit that referenced this issue Dec 10, 2024
@capricorn86
chore: [#1615] Continues on implementation
c1b1b40
capricorn86 added a commit that referenced this issue Dec 11, 2024
@capricorn86
chore: [#1615] Continues on implementation
dbe90fa
capricorn86 added a commit that referenced this issue Dec 13, 2024
@capricorn86
chore: [#1615] Continues on implementation
6782f57
capricorn86 added a commit that referenced this issue Dec 13, 2024
@capricorn86
chore: [#1615] Continues on implementation
8302176
capricorn86 added a commit that referenced this issue Dec 17, 2024
@capricorn86
chore: [#1615] Continues on implementation
2bf2349
capricorn86 added a commit that referenced this issue Dec 20, 2024
@capricorn86
chore: [#1615] Continues on implementation
3ff4650
capricorn86 added a commit that referenced this issue Dec 21, 2024
@capricorn86
chore: [#1615] Continues on implementation
700f16e
capricorn86 added a commit that referenced this issue Dec 21, 2024
@capricorn86
chore: [#1615] Continues on implementation
9407af9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@OlaviSau