Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to generate dist and docs files with the same syntax #39

Open
bpinto opened this issue Feb 12, 2021 · 0 comments · May be fixed by #41
Open

Failing to generate dist and docs files with the same syntax #39

bpinto opened this issue Feb 12, 2021 · 0 comments · May be fixed by #41

Comments

@bpinto
Copy link

bpinto commented Feb 12, 2021

Running npm run watch (or npm run prepare directly) is generating a lot of local changes. I'm not sure if I'm missing come configuration.

> git status

M  dist/karet.xhr.cjs.js
M  dist/karet.xhr.es.js
M  dist/karet.xhr.js
M  dist/karet.xhr.min.js
M  docs/karet.xhr.js
❯ git diff | head -n 40
diff --git a/dist/karet.xhr.cjs.js b/dist/karet.xhr.cjs.js
index b5d32de..104c77e 100644
--- a/dist/karet.xhr.cjs.js
+++ b/dist/karet.xhr.cjs.js
@@ -148,6 +148,8 @@ var typeLoad = /*#__PURE__*/I.freeze({ type: LOAD });
 
 var eventTypes = [LOADSTART, PROGRESS, LOAD, TIMEOUT, ERROR];
 
+var simpleSettings = [OVERRIDE_MIME_TYPE, RESPONSE_TYPE, TIMEOUT, WITH_CREDENTIALS];
+
 var hasKeys = function hasKeys(x) {
   return I.isFunction(x.keys);
 };
@@ -164,37 +166,32 @@ var headersMap = /*#__PURE__*/V.and( /*#__PURE__*/V.acceptWith(function (xs) {
 }));
 
 var performPlain = /*#__PURE__*/(process.env.NODE_ENV === 'production' ? I.id : V.validate(V.freeFn(V.tuple(V.props({
-  url: string,
-  method: V.optional(string),
-  user: V.optional(string),
-  password: V.optional(string),
+  body: V.optional(V.accept),
   headers: V.propsOr(headerValue, I.object0),
+  method: V.optional(string),
   overrideMimeType: V.optional(string),
-  body: V.optional(V.accept),
+  password: V.optional(string),
   responseType: V.optional(string),
   timeout: V.optional(number),
+  url: string,
+  user: V.optional(string),
   withCredentials: V.optional(boolean)
 })), V.accept)))(function perform(args) {
   return delayUnsub(K.stream(function (_ref) {
     var emit = _ref.emit,
         end = _ref.end;
 
-    var url = args.url;
     var method = args.method;
     var user = args.user;

Do you know what could be happening? Thank you.

bpinto added a commit to bpinto/karet.xhr that referenced this issue Feb 15, 2021
@bpinto bpinto linked a pull request Feb 15, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant