Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11245: Add tooltip to 'Altered group' axis label for box plot statistics #5073

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chandrikarj
Copy link

Fix cBioPortal/cbioportal#11245

Describe changes proposed in this pull request:

  • Added a tooltip to the "Altered group" axis label to display box plot statistics.
  • Tooltip content matches the statistical information shown when hovering over the box.

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Any screenshots or GIFs?

Before :
Before

After :
After

Notify reviewers

Read our Pull request merging
policy
. It can help to figure out who worked on the
file before you. Please use git blame <filename> to determine that
and notify them either through slack or by assigning them as a reviewer on the PR

Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit b8c1bce
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/67693ea759d5a5000815bdf2
😎 Deploy Preview https://deploy-preview-5073.cancerrevue.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chandrikarj
Copy link
Author

Hi @inodb, could you pls review and suggest the required changes?

@alisman
Copy link
Collaborator

alisman commented Jan 3, 2025

@chandrikarj thanks for this PR and sorry for my tardiness. I think it would be much preferable to use the model we already have for introducing custom HTML tooltips into Victory plots. You can see that at work in
src/shared/components/plots/BoxScatterPlot.tsx ~l164

This avoids leaving React paradigm in the way that you do.

Let me know if you have any questions.

Copy link
Collaborator

@alisman alisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add boxplot stats as tooltip for axis label
2 participants