Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Go 1.23 #59

Closed
haoxins opened this issue Aug 14, 2024 · 4 comments
Closed

Support Go 1.23 #59

haoxins opened this issue Aug 14, 2024 · 4 comments

Comments

@haoxins
Copy link

haoxins commented Aug 14, 2024

Describe the bug

When run with Go 1.23

link: github.com/bytedance/mockey/internal/monkey/common: invalid reference to runtime.sysAllocOS

See cloudwego/hertz#1171

@Sychorius
Copy link
Collaborator

We will fix it in next release

@Sychorius
Copy link
Collaborator

@haoxins
go1.23 disallows using //go:linkname so here we can not link to sysAllocOS directly
You can add -ldflags=-checklinkname=0 into test command to temporarily bypass this restriction.
We are trying to find a better way to fix it

@haoxins
Copy link
Author

haoxins commented Aug 15, 2024

@haoxins go1.23 disallows using //go:linkname so here we can not link to sysAllocOS directly You can add -ldflags=-checklinkname=0 into test command to temporarily bypass this restriction. We are trying to find a better way to fix it

It works for me, thanks~

@Sychorius
Copy link
Collaborator

@haoxins Fixed in v1.2.11, you can upgrade go.mod dependency

@haoxins haoxins closed this as completed Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants