Added Avatar image prop #287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gabro
requested changes
Jul 20, 2022
Comment on lines
54
to
61
| <img | ||
| style={{ display: imageAvailable ? "block" : "none" }} | ||
| src={imageSrc} | ||
| className={avatarImage({})} | ||
| onLoad={handleImageLoaded} | ||
| onError={handleImageErrored} | ||
| /> |
There was a problem hiding this comment.
I propose we use <Box as="img"> here, which also gives you the ability to use display directly (<Box display={imageAvailable ? "block" : "none"} />)
Comment on lines
27
to
29
| export const avatarImage = strictRecipe({ | ||
| base: bentoSprinkles({ | ||
| width: "full", | ||
| }), | ||
| }); |
There was a problem hiding this comment.
no need to use a recipe here, you can directly use bentoSprinkles.
Reggionick
force-pushed
the
275-support-images-in-avatar
branch
from
bc532aa to
74948aa
Compare
auto-merge was automatically disabled
October 14, 2022 10:03
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.