-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Params in Bugsnag is incorrect with non-json data #302
Comments
Hi @ragingdave, thanks for the feature request! I've raised it with our products team and we'll try and update you on when things progress. In the meantime, are you able to add your data manually by adding a callback? |
I actually ended up just converting the non-json data to a param on the request as a pseudo-attribute so it would get picked up by the request->input() call. The problem with the callback is that only certain requests in the application come through as xml so a global callback is a bit overkill for my usage.
… On Jun 5, 2018, at 7:05 AM, Alex Moinet ***@***.***> wrote:
Hi @ragingdave <https://github.com/ragingdave>, thanks for the feature request! I've raised it with our products team and we'll try and update you on when things progress. In the meantime, are you able to add your data manually by adding a callback <https://docs.bugsnag.com/platforms/php/laravel/customizing-error-reports/#adding-callbacks>?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#302 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABHT2GJIk8ZE2LWucYvh3CZWFT3INPAYks5t5mX_gaJpZM4UJVEx>.
|
You can also register a callback in a specific controller so that the callback would only be added when the routes that receive the XML/SOAP data is called. |
I'm closing this for now, but I'll update it as the feature request progresses. Edit - We're going to keep this open as a place to reference as progression for the feature request |
Expected behavior
When something like SOAP or xml is posted to laravel and an exception occurs I would expect to see that in the bugsnag interface under params.
Observed behavior
When something like SOAP or xml is posted to laravel and an exception occurs params is an empty array.
Steps to reproduce
Post XML data to a route and throw an exception note that the request in bugsnag is empty.
Version
Bugsnag: 3.10
Bugsnag Laravel: 2.11.1
Would something like a "raw" metadata addition be something that could be populated by
getContent()
rather than just relying oninput()
to get the post data?The text was updated successfully, but these errors were encountered: