Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only run expl3-dependent tests in continuous integration #2234

Merged
merged 2 commits into from
Oct 15, 2023

Conversation

dginev
Copy link
Collaborator

@dginev dginev commented Oct 13, 2023

This PR is essentially a repeat on my first attempt in #2045, and is one way to interpret the sentiment I recently expressed in #2175 and #2204.

Namely, I suggest we temporarily only run expl3-related tests in continuous integration, allowing systems where latexml's expl3 emulation is broken to still have a clean/successful installation. Those are currently two tests - glossary and si. Also, this is specifically targeted to the 0.8.8 release of latexml.

For the next, 0.8.9 release, I think Bruce has shown some convincing prototypes where both the performance in loading expl3 can be improved, as well as the robustness in interpretation, but that will require some sweeping changes to the pool-related internals of Core processing.

P.S. Attached with taking this route would be a suggestion to defer resolving #2204 until after the more ambitious approach to expl3 loading is in place.

@brucemiller
Copy link
Owner

Yeah, sadly it seems like it's time to do this. Hopefully we'll be able to back off soonish.

But since you've "formalized" the CI switch, shouldn't we tweak the existing CI tests to use the same tagging (to avoid surprises later)? Those seem to be t/83_expl3.t, t/170_grammar_coverage.t, t/97_manifest.t

@dginev dginev force-pushed the defer-more-tests-to-CI branch from b29a7b2 to dd69c74 Compare October 13, 2023 22:58
@dginev
Copy link
Collaborator Author

dginev commented Oct 13, 2023

Sure. I rebased to master and switched t/83_expl3.t to the new idiom.

But the other two cases - t/170_grammar_coverage.t and t/97_manifest.t are not testing individual .tex files, and thus do not rely on LaTeXML::Util::Test, so they can't really be unified more? At least I am not sure how that would look.

@brucemiller
Copy link
Owner

Cool! Thanks!

@brucemiller brucemiller merged commit 56886ab into brucemiller:master Oct 15, 2023
13 checks passed
@brucemiller brucemiller deleted the defer-more-tests-to-CI branch October 15, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants