Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML Safe is the opposite of rails convention #210

Open
SampsonCrowley opened this issue Mar 25, 2022 · 0 comments
Open

HTML Safe is the opposite of rails convention #210

SampsonCrowley opened this issue Mar 25, 2022 · 0 comments

Comments

@SampsonCrowley
Copy link

Now, I'm very aware this is not a Rails gem; but what you've called the html_safe flag, even though your usage is much more accurate to the name of the flag (and while I also hate the way the rails guys named that one in particular), I think you could take a page from the rails book there. The rails convention is everything not flagged should be escaped, and adding html_safe means you've already escaped and cleared it.

The same concepts maybe don't apply here because it's a JSON library; but just food for thought

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant