Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose additional Reverse Swap data in resulting Payment #1029

Closed
danielgranhao opened this issue Jul 1, 2024 · 1 comment
Closed

Expose additional Reverse Swap data in resulting Payment #1029

danielgranhao opened this issue Jul 1, 2024 · 1 comment

Comments

@danielgranhao
Copy link
Contributor

danielgranhao commented Jul 1, 2024

There is currently no way to get the fees spent in past reverse swaps. It would be useful if a Payment resulting from a reverse swap included fee information like fees_claim, fees_lockup and total_fees. These are currently only provided when preparing an onchain send.

One option would be to include this data in ReverseSwapInfo.

Additionally, the recipient onchain address is not exposed, which can be useful for a user who wants to check where he sent funds to.

@danielgranhao danielgranhao changed the title Expose Reverse Swap fees in resulting Payment Expose additional Reverse Swap data in resulting Payment Jul 1, 2024
@danielgranhao
Copy link
Contributor Author

Duplicate of #1111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant