Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect parameter ordering in element_sub #129

Open
isaac868 opened this issue Aug 17, 2021 · 4 comments · May be fixed by #146
Open

Incorrect parameter ordering in element_sub #129

isaac868 opened this issue Aug 17, 2021 · 4 comments · May be fixed by #146
Assignees
@stefanseefeld
Labels
bug

Comments

@isaac868
Copy link

The parameter ordering of a call to element_wise within one of the element_sub overloads is incorrect.

Since the function signature of element_wise is:

void element_wise(ublas::matrix<T, L1, opencl::storage> const &a,
	ublas::matrix<T, L2, opencl::storage> const &b,
	ublas::matrix<T, L3, opencl::storage> &result,
	O op, compute::command_queue& queue)

The call in the first element_sub overload should be changed to:
element_wise(a, b, result, compute::minus<T>(), queue);
as opposed to
element_wise(a, b, compute::minus<T>(), result, queue);
@isaac868 isaac868 mentioned this issue Aug 17, 2021
Open
@bassoy bassoy assigned bassoy and stefanseefeld and unassigned bassoy Sep 6, 2021
@bassoy bassoy added the bug label Sep 6, 2021
harjot20022001 added a commit to harjot20022001/ublas that referenced this issue Dec 29, 2021
@harjot20022001
Incorrect parameter ordering in element_sub boostorg#129
b2ba867
@harjot20022001
Copy link

I have submitted a pr that had passed the checks. Can someone review it so it can be merged?

@harjot20022001 harjot20022001 linked a pull request Dec 30, 2021 that will close this issue
Open
@Neel-Shah-29
Copy link
Contributor

Is there any ongoing effort to solve this issue? If not, I am interested in working on it. Please assign the task to me

@Neel-Shah-29 Neel-Shah-29 mentioned this issue Jan 9, 2022
Closed
@Neel-Shah-29
Copy link
Contributor

Is this issue resolved or yet remaining to be solved?

@isaac868
Copy link
Author

It is not resolved yet. It appears there is are two prq's for this at #128 and #146 (review). However, they need two people with write access to approve them. The one wihtout all the merge conflicts should probably be the one merged into the develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanseefeld stefanseefeld

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Incorrect parameter ordering in element_sub harjot20022001/ublas
5 participants
@stefanseefeld @bassoy @isaac868 @harjot20022001 @Neel-Shah-29