-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std::uint64_t numbers above a certain value are not formatted correctly #235
Comments
Flamefire
added a commit
that referenced
this issue
Aug 8, 2024
As reported in #235 formatting the first number which doesn't fit into int64_t anymore fails to add the thousands separators. I.e.: `9223372036854775807` -> `9,223,372,036,854,775,807` `9223372036854775808` -> `9223372036854775808` Add a test reproducing that that for all backends.
Flamefire
added a commit
that referenced
this issue
Aug 8, 2024
As reported in #235 formatting the first number which doesn't fit into int64_t anymore fails to add the thousands separators. I.e.: `9223372036854775807` -> `9,223,372,036,854,775,807` `9223372036854775808` -> `9223372036854775808` Add a test reproducing that that for all backends.
The problem is that ICU only supports formatting
So any integer value above I'm working on a solution |
Flamefire
added a commit
that referenced
this issue
Dec 5, 2024
As reported in #235 formatting the first number which doesn't fit into int64_t anymore fails to add the thousands separators. I.e.: `9223372036854775807` -> `9,223,372,036,854,775,807` `9223372036854775808` -> `9223372036854775808` Add a test reproducing that that for all backends.
Flamefire
added a commit
that referenced
this issue
Dec 5, 2024
ICU doesn't support uint64_t directly but provides access to formatting and parsing of decimal number strings. Use Boost.Charconv to interface with that. Fixes #235
Flamefire
added a commit
that referenced
this issue
Dec 30, 2024
As reported in #235 formatting the first number which doesn't fit into int64_t anymore fails to add the thousands separators. I.e.: `9223372036854775807` -> `9,223,372,036,854,775,807` `9223372036854775808` -> `9223372036854775808` Add a test reproducing that that for all backends.
Flamefire
added a commit
that referenced
this issue
Dec 30, 2024
ICU doesn't support uint64_t directly but provides access to formatting and parsing of decimal number strings. Use Boost.Charconv to interface with that. Fixes #235
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Boost version: 1.83.000
Compiler : GCC 13.2.0
std::uint64_t numbers above a certain value are not formatted correctly:
in the following minimal example
first
is formatted correctly (commas are used as separators), whilesecond
is not correctly formatted (no commas are used)Example:
Console output:
9,223,372,036,854 9223372036854775808
The text was updated successfully, but these errors were encountered: