Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster digest #601

Open
vinniefalco opened this issue Aug 4, 2021 · 1 comment · May be fixed by #606
Open

Faster digest #601

vinniefalco opened this issue Aug 4, 2021 · 1 comment · May be fixed by #606
Labels
Performance Related to optimization of space or size

Comments

@vinniefalco
Copy link
Member

When calculating digests of strings, we could operate 4 or 8 characters at a time. First we need to run the profile to see what the current digest algorithm costs us during parsing.
@vinniefalco vinniefalco added the Performance Related to optimization of space or size label Aug 7, 2021
@grisumbras
Copy link
Member

grisumbras commented Aug 8, 2021 •
edited
Loading

Here's my benchmarking based on 4 approaches from PR #606 (each commit is a different approach).
https://disk.yandex.ru/i/7tKxDT2YG3o-Yw

@grisumbras grisumbras linked a pull request Aug 8, 2021 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Performance Related to optimization of space or size
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Digest calculated in batches of sizeof(size_t) grisumbras/json
2 participants
@vinniefalco @grisumbras