Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shifts in the text selection range being detected in vscode, and given to Leo prior to executing a command. #198

Open
boltex opened this issue Aug 27, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@boltex
Copy link
Owner

boltex commented Aug 27, 2021

As reported by @ATikhonov2 : "There is a strange thing with the command "extract", which often (but not always) happens"

Figure out how to correct the detection of the selected text range and its setup in Leo. (There is also a conversion algorithm applied in between because on one side it's just a string position, and on the other it's a row and col duo.) So there's a couple places things can go wrong!

@boltex boltex added the bug Something isn't working label Aug 27, 2021
@boltex boltex self-assigned this Aug 27, 2021
@edreamleo
Copy link
Collaborator

@boltex FYI, the extract command expands the selection range to include all of the first and lines. I have no idea whether this is part of the problem for leoInteg, but Leo's behavior is necessary.

@boltex
Copy link
Owner Author

boltex commented Aug 28, 2021

@edreamleo Thanks, yes I already knew this as I often use this feature to lazily select the rows I want to be extracted. (no need to carefully select from the first character of the first row needed to the last character of the last row, which is very useful)

I've been a bit busy lately but I'll start working on this tomorrow to get to the bottom of this. (selection range detection in leointeg and conversion to usable structure in leoserver.)

@boltex boltex modified the milestone: 1.0 Sep 13, 2021
@boltex
Copy link
Owner Author

boltex commented Sep 19, 2021

Cant reproduce precisely - might be caused by unrelated code/side-effects. Needs more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants