Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #159 - Use LinkedHashSet to store sets #161

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Fix #159 - Use LinkedHashSet to store sets #161

wants to merge 23 commits into from

Conversation

CheShianHung
Copy link
Contributor

@CheShianHung CheShianHung commented Oct 11, 2017 •
edited by psybers
Loading

Fixes #159

@psybers psybers self-requested a review October 11, 2017 20:50
psybers
psybers requested changes Oct 11, 2017
View reviewed changes
Copy link
Member

@psybers psybers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anywhere the variable is declared, the type should be the more general type Set. Only when instantiated do we want a concrete type LinkedHashSet.

psybers
psybers requested changes Oct 12, 2017
View reviewed changes
src/java/boa/aggregators/SetAggregator.java Outdated Show resolved Hide resolved
src/java/boa/functions/BoaIntrinsics.java Outdated Show resolved Hide resolved
src/java/boa/functions/BoaIntrinsics.java Outdated Show resolved Hide resolved
src/java/boa/functions/BoaIntrinsics.java Outdated Show resolved Hide resolved
src/java/boa/functions/BoaIntrinsics.java Outdated Show resolved Hide resolved
src/java/boa/graphs/cfg/CFGNode.java Outdated Show resolved Hide resolved
src/java/boa/graphs/cfg/CFGNode.java Outdated Show resolved Hide resolved
src/java/boa/graphs/cfg/CFGNode.java Outdated Show resolved Hide resolved
src/java/boa/graphs/cfg/CFGNode.java Outdated Show resolved Hide resolved
src/java/boa/graphs/cfg/CFGNode.java Outdated Show resolved Hide resolved
psybers
psybers requested changes Aug 15, 2019
View reviewed changes
Copy link
Member

@psybers psybers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesnt pass tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psybers psybers psybers approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use LinkedHashSet to store sets
2 participants
@CheShianHung @psybers