Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs form validation handling #185

Open
GarrettWeinberg opened this issue Aug 17, 2024 · 2 comments
Open

Needs form validation handling #185

GarrettWeinberg opened this issue Aug 17, 2024 · 2 comments

Comments

@GarrettWeinberg
Copy link

I noticed this by added the meeting start time without the AM/PM selector. Form did not submit and I did realize the error quickly, but some sort of validation summary would be helpful. I also tried submitting the new meeting form without filling out any fields and there is no messaging on any required fields. IMO at the minimum each required field or invalid field should be highlighted red with a message under it explaining the issue and how to resolve the issue.

@nigel-bmlt
Copy link
Collaborator

This seems reasonable. At least on the browser I'm testing with the form validation jumps you to the first invalid field, but there's certainly no text to indicate why the validation failed. I'll see if i can find a reasonable template/format for this that looks ok and will implement in the next release. If you have a screenshot or a link to show 'what good looks like' please share.

@GarrettWeinberg
Copy link
Author

I've always just used bootstrap validation. If you are bringing in bootstrap, that would be my suggestion. If not, then maybe just make a red border around the fields? I don't think it needs to be crazy, just something to stand out. Others may have different opinions tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants