Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #912 #913

Merged
merged 15 commits into from
Oct 23, 2024
Merged

Conversation

davidkartchner
Copy link
Contributor

@davidkartchner davidkartchner commented Jan 26, 2024

Closes 912

  • Confirm that this PR is linked to the dataset issue.
  • Create the dataloader script hub/hub_repos/my_dataset/my_dataset.py (please use only lowercase and underscore for dataset naming).
  • Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _BIGBIO_VERSION variables.
  • Implement _info(), _split_generators() and _generate_examples() in dataloader script.
  • Make sure that the BUILDER_CONFIGS class attribute is a list with at least one BigBioConfig for the source schema and one for a bigbio schema.
  • Confirm dataloader script works with datasets.load_dataset function.
  • Confirm that your dataloader script passes the test suite run with python -m tests.test_bigbio_hub <dataset_name> [--data_dir /path/to/local/data] --test_local.
  • If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

Copy link
Collaborator

@phlobo phlobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @davidkartchner, please have a look at my comments, I cannot run the unit tests at the moment due to a wrong import. Also, I guess the requirements.txt was deleted accidentally.

bigbio/hub/hub_repos/sourcedata_nlp/sourcedata_nlp.py Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
@phlobo phlobo self-assigned this Jul 22, 2024
@phlobo
Copy link
Collaborator

phlobo commented Oct 21, 2024

@mariosaenger I implemented the requested changes myself, could you please have a final look at the PR before merging?

@phlobo phlobo requested a review from mariosaenger October 21, 2024 12:54
Copy link
Collaborator

@mariosaenger mariosaenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for implementing and fixing this!

@mariosaenger mariosaenger merged commit 6f69f10 into bigscience-workshop:main Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants