-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP #60 #681
Merged
Merged
WIP #60 #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues with `download_and_extract()`
shamikbose
requested review from
hakunanatasha,
jason-fries,
sunnnymskang,
ruisi-su,
galtay,
leonweber,
sg-wbi and
debajyotidatta
as code owners
June 4, 2022 20:42
Updated to show the code which was being run earlier. Format is "CRAFT-5.0.0\concept-annotation\key\key"
- Passes all tests - Warnings logged for multiple annotations
UPDATE: This passes all tests as a local dataset. However, I have a few more follow-up questions:
|
General changes: - Updated paths to use `os.path.join()` to make it platform-agnostic MONDO specific changes: - Specific ways to read annotations - Specific ways to find corresponding annotations
_PUBMED set to True
@phlobo I adjusted the implementation. Please have a look at it. |
Resolves #938 |
phlobo
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues with
download_and_extract()
NOTE: This is WIP. Folder structures are being lost when using
download_and_extract()
Manual extraction:
Extraction using
download_manager
:Checkbox
biodatasets/my_dataset/my_dataset.py
(please use only lowercase and underscore for dataset naming)._CITATION
,_DATASETNAME
,_DESCRIPTION
,_HOMEPAGE
,_LICENSE
,_URLs
,_SUPPORTED_TASKS
,_SOURCE_VERSION
, and_BIGBIO_VERSION
variables._info()
,_split_generators()
and_generate_examples()
in dataloader script.BUILDER_CONFIGS
class attribute is a list with at least oneBigBioConfig
for the source schema and one for a bigbio schema.datasets.load_dataset
function.python -m tests.test_bigbio biodatasets/my_dataset/my_dataset.py
.