Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test with the ancients. #383

Open
bigeasy opened this issue Apr 3, 2021 · 1 comment
Open

Test with the ancients. #383

bigeasy opened this issue Apr 3, 2021 · 1 comment
Assignees
@bigeasy
Labels
enhancement
Milestone
Gimme that old ti...

Comments

@bigeasy
Copy link
Owner

bigeasy commented Apr 3, 2021

If you add that ability to Proof, you can test with the ancients and still get 100% coverage of the promise additions by writing the tests so that they return a Thenable instead of a Promise.
@bigeasy bigeasy added this to the Gimme that old time religion. milestone Apr 3, 2021
@bigeasy bigeasy self-assigned this Apr 3, 2021
@bigeasy
Copy link
Owner Author

bigeasy commented Jul 30, 2021

How would we go about testing with the ancients, though? Proof is no longer tested against pre-async/await Node.js because one of its dependencies uses a static ES6 declaration. We'd have to revert changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bigeasy bigeasy

Labels
enhancement
Projects
None yet
Milestone
Gimme that old time religion.
Development

No branches or pull requests
1 participant
@bigeasy