Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ellipsis as pass #11

Open
cepbuch opened this issue Mar 16, 2020 · 1 comment
Open

Ellipsis as pass #11

cepbuch opened this issue Mar 16, 2020 · 1 comment

Comments

@cepbuch
Copy link
Contributor

cepbuch commented Mar 16, 2020

Hi!

Can we use ellipsis operator as pass to cover dummy classes like:

class Foo:
   ...

?

For those who prefer to use it over pass. I didn't find any clarification whether pass or ... is recommended.

We can just slightly change logic in ast.Expr handling to distinguish ast.Ellipsis as pass. Of course to be more strict we can add config var like pass_attribute=pass|..., but imho this is not about this plugin.

@Melevir
Copy link
Contributor

Melevir commented Mar 17, 2020

Thanks for the issue.
For me pass is ok, but ... is not ok, so I don't like the idea of allowing both of them.
Option with pass_attribute seems nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants