You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The part that accounts for roman numeral suffixes is [IVX]{2,}, which looks for 2 or more characters, while V or X would only be one.
Perhaps this is intentional, because looking for a single character may be problematic and cause a lot of false positives, but I wanted to create an issue for it and see.
The text was updated successfully, but these errors were encountered:
If I remember correctly, your guess is right: we used this default pattern to avoid false positives matching initials. All these patterns are configurable (e.g., Namae::Parser.instance.options for the singleton instance), so if you expect those kind of suffixes (or do not expect initials) you can just use a more suitable default.
If a name has a suffix of V (fifth), it is considered a
family
name, not the suffix:This is because the suffix regex is:
/\s*\b(JR|Jr|jr|SR|Sr|sr|[IVX]{2,})(\.|\b)/
The part that accounts for roman numeral suffixes is
[IVX]{2,}
, which looks for 2 or more characters, while V or X would only be one.Perhaps this is intentional, because looking for a single character may be problematic and cause a lot of false positives, but I wanted to create an issue for it and see.
The text was updated successfully, but these errors were encountered: