Improvements & Fixes to MyWorlds

[LaurenceBarnes]

Summary:

1. Fix for the nether not working when being unloaded and loaded again if MyWorld's Portal teleportation management is turned off
2. Fix for the nether loading during a start despite being unloaded in worlds.yml if AllowNether is set to true in server.properties, in that case just let the game what it wants to do and unload it immediately after starting is finished
3. Add compatibility for custom nether/overworld scales set by datapacks - fixed
4. Fix a crash regarding TwistingVines maxGrowthAge being set to more than 25 in purpur.yml fixed by purpur
5. Fix POI warnings - fixed

Longer explanations:

1. when vanilla handles the portals, when I unload the nether with MyWorlds and load it again, the portal doesn't send me through. I need to restart the server in order for portals to work again, which is a bit inconvenient.
2. this is just a QoL thing, it would be nice to be able to allow the nether in the server.properties while still keeping it deactivated so one can activate it on demand. I guess a simple solution would be that MyWorlds checks and unloads unloaded worlds after the server has been started
3. This is an issue that totally prevents any usage of a datapack changing the nether scale. Of course there are many legitimate reasons for wanting this, for example when a server either wants to nerf the nether or even increase its effectiveness, which allows for customizations. If there is an uncomplicated solution to this by reading datapacks, it would be great. It would be inconvenient having to set it in myWorlds as well, but of course having an option to configure it in MyWorlds would not be bad as well (during the creation of the nether then)
4. This is rather critical and I could isolate the issue to MyWorlds. The Purpur.yml allows to configure the MaxGrowthAge of twisting Vines and Kelp. I don't know if a value above 25 is even allowed, but in either way it should not cause a crash.
   The server log looks like this:
   https://mclo.gs/fQ6WFzM
   https://pastebin.com/1j2Wbr9z (as a backup paste)
   The only solution to this is interestingly to deactivate MyWorld's Portal teleportation handling, which is how I encountered the other issues. However, when doing /tpp into the nether despite MyWorld's portal logic being deactivated, the server crashes anyway. no it's a Minecraft issue and irrelevant
5. Just added to this issue because it turned out to be a part of what I encountered

For the whole process of finding out those bugs read here https://discord.com/channels/415909893233442826/607574123366973461/830536232811102248

Otherwise, don't hesitate to ping me whenever you need me to test something! :D

[LaurenceBarnes]

double_nether_height.zip
nether_scale_1.0.zip

The two resource packs. I use "double nether height" only and changed the value in its configuration.

One note regarding the nether height resource pack:

Installation of this pack was a little weird for me. It didnt work right away. What I did to get it to work was let the nether world directory build by running the server. Once it was built and populated I shut the server down and then deleted all the mca files in the nether regions directory, leaving everything else intact (this will wipe your nether, btw). Bring the server back up and check to see if your nether roof is at 256 instead of 128. If not, try again unti it does.

[LaurenceBarnes]

PurpurMC/Purpur@0623652

That explains the vines crashing issue, so at least this part is resolved