fix expressions array in compile #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
jwalton
suggested changes
Sep 7, 2018
src/NodeWrapper.coffee
Outdated
| line = if node.locationData? | ||
| node.locationData.first_line | ||
| else | ||
| throw new Error |
There was a problem hiding this comment.
I don't understand this fix - doesn't this throw new Error stop us from reaching the next line? O_o
There was a problem hiding this comment.
correct, silly line (177).
i removed it.
There was a problem hiding this comment.
made a git mistake so i will reopen the pr.
orengriffin
force-pushed
the
fix-first-line
branch
from
12e6f8a to
e80b5ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue 93# i encountered
this is a very naive fix.