-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPv6 regex matches on "::" #201
Comments
Can you explain a little more? |
It matches a false positive value. The changes of regex may be required or, if regex seems to be perfect, its rarity should be lowered. |
I think we should remove |
What do you mean by that? We can't remove all instances of |
Why not? I doubt the IPv6 address regex will 100% break if we ask it to not match things which are 2 characters Also, please explain why it won't work in the future instead of making me ask you why :) Saves a lil bit of time / effort ! :) |
Sorry I got confused and thought you meant removing all instances of
Now I'm confused again.
The reason it wouldn't work is because some IPv6 addresses use |
I worked on the IPv6 regex, so I can explain why and in what case this happens. :) Regex doesn't just match to plain
That is correct. This is why I didn't put any more restrictions in. IPv6 can start or end or have |
This shouldn't match.
The text was updated successfully, but these errors were encountered: