-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL regex does not fully match every URL #117
Labels
Regex issue
Regex is not full or matches a lot of false positives
Comments
The reason we do this is because of false positives by the way :) |
sad |
ghost
self-assigned this
Jul 19, 2021
ghost
mentioned this issue
Jul 19, 2021
Merged
ghost
changed the title
URL regex does not return all possible matches
URL regex does not fully match every URL
Jul 21, 2021
Reopening this since pywhat does not match something like https://www.google.com fully. |
ghost
reopened this
Jul 21, 2021
ghost
removed their assignment
Jul 24, 2021
Hey, @amadejpapez, do you have any ideas about this one? |
Hm will check this later today and see if I get any. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For example:
I would like it to return both google.co and google.com. Sadly, it may be impossible considering the way regular expressions work. Thus, it would be amazing to match the longest string (
pywhat google.com/help
should returngoogle.com/help
). It is crucial for implementing URL subcategories properly(#51). Btw, URL regex is too long, I do not think that valid TLDs should be checked, so it may be shortened.The text was updated successfully, but these errors were encountered: