Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration File Uses yii\db\Migration Instead of Audit-Specific Migration. #296

Open
Ahmadjlallad opened this issue Dec 2, 2024 · 2 comments

Comments

@Ahmadjlallad
Copy link

Hey, I noticed that the migration files m231117_101719_alter_audit_trail and m231117_102354_alter_audit_entry use yii\db\Migration as the base class. This works fine generally, but since I’m migrating the audit module to a sprite database, it would make more sense to use bedezign\yii2\audit\components\Migration.

This way, the migrations will automatically use the database connection configured for the audit component.

If it helps, I’d be happy to open a PR to make the change. Let me know if that works for you!

@schmunk42
Copy link
Contributor

If it helps, I’d be happy to open a PR to make the change. Let me know if that works for you!

Yes, that would be great!

@Ahmadjlallad
Copy link
Author

Yes, that would be great!

Thanks! I’ve opened a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants