Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing all login / user account management #26

Open
florianmari opened this issue Dec 21, 2023 · 7 comments
Open

Removing all login / user account management #26

florianmari opened this issue Dec 21, 2023 · 7 comments

Comments

@florianmari
Copy link
Contributor

Hey,

Since it relies on a backend, should we just remove all login flow / component?

@remstos
Copy link
Contributor

remstos commented Dec 21, 2023

Yeah there’s no reason it will come back any time soon, right? At best we will have a CloudKit sync, but never a login again.
So I’m ok with just clearing out all that code ✅

@florianmari
Copy link
Contributor Author

https://welcometour.beamapp.co/ would be great to have this repo and keep the onboarding working if it would disappeared one day. Maybe this could be embedded at some point

@florianmari
Copy link
Contributor Author

This is really big task to remove the network layer will take time I think I'll subtask everything and do it on some UI screens then removing network related code

@StefKors
Copy link
Member

StefKors commented Jan 9, 2024

I pushed the welcome tour to github: https://github.com/beamlegacy/welcome-tour fyi

@florianmari
Copy link
Contributor Author

🚀

@McNight
Copy link
Contributor

McNight commented Jan 22, 2024

There are some failing tests in BeamAccountRemoteServerTest 😢

@florianmari
Copy link
Contributor Author

@McNight Taking care of that tonight! Thanks, will fix / remove the relevant tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants