Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aries VCR Org Number Search is case sensitive #508

Closed
ianco opened this issue May 14, 2020 · 1 comment · Fixed by #603
Closed

Aries VCR Org Number Search is case sensitive #508

ianco opened this issue May 14, 2020 · 1 comment · Fixed by #603

Comments

@ianco
Copy link
Contributor

ianco commented May 14, 2020

I just discovered Orgbook is case sensitive. When I enter bc0491266 it says No Results however BC0491266 finds the company. I’ve tried this with a couple different sole props and the same thing happened. This seems like a major flaw in searching for entities.

@ianco
Copy link
Contributor Author

ianco commented Jul 29, 2020

This is a bug in the V2 API's

In the V3 API's it's a mixed bag, the /search/autocomplete endpoint is not case sensitive ("bc0491266" and "BC0491266" both return the same results), however the /search/credential and /search/topic endpoints are both case sensitive on the company number (nut not the company name or address).

So, if we switch over to the V3 API's and hook up the name search to the /search/autocomplete endpoint it will fix this issue. (Or we can fix the other endpoints to be case in-sensitive)

@amanji amanji linked a pull request Dec 29, 2020 that will close this issue
@ianco ianco closed this as completed in #603 Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant