From 3b65b057de4b36d90f3211ab50341370e2c94fbe Mon Sep 17 00:00:00 2001 From: Googler Date: Mon, 18 Nov 2024 03:24:38 -0800 Subject: [PATCH] Make Bazel not crash if a runfiles tree is in a runfiles tree. There was a test for this, but it didn't check for the exit code, only the error message and the message printed on the crash coincidentally contained the expected message. My best understanding is that this was broken in unknown commit. The root cause of why that change was imperfect is probably the odd behavior that if one posts an error to the event handler in ActionExecutionContext, the action doesn't automatically fail. RELNOTES: None. (cherry picked from commit ebced6600fdd083fef00461be777737e7eeb8b84) --- third_party/bazel/src/main/protobuf/failure_details.proto | 1 + 1 file changed, 1 insertion(+) diff --git a/third_party/bazel/src/main/protobuf/failure_details.proto b/third_party/bazel/src/main/protobuf/failure_details.proto index 979f8cb7171..59925659e0a 100644 --- a/third_party/bazel/src/main/protobuf/failure_details.proto +++ b/third_party/bazel/src/main/protobuf/failure_details.proto @@ -1256,6 +1256,7 @@ message Analysis { INCOMPATIBLE_TARGET_REQUESTED = 19 [(metadata) = { exit_code: 1 }]; ANALYSIS_FAILURE_PROPAGATION_FAILED = 20 [(metadata) = { exit_code: 1 }]; ANALYSIS_CACHE_DISCARDED = 21 [(metadata) = { exit_code: 1 }]; + INVALID_RUNFILES_TREE = 22 [(metadata) = { exit_code: 1 }]; } Code code = 1;