Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Java runfiles library out of Bazel #24394

Closed
wants to merge 4 commits into from
Closed

Move Java runfiles library out of Bazel #24394

wants to merge 4 commits into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Nov 19, 2024

No description provided.

@fmeum
Copy link
Collaborator Author

fmeum commented Nov 19, 2024

@hvadehra The CI failures on this PR look like they shouldn't be related to my changes, did something else change?

@hvadehra
Copy link
Member

This is still a work in progress, please hang on / wait for the final release.

@hvadehra
Copy link
Member

Should go through in #24391

@fmeum fmeum force-pushed the drop-java-runfiles-library branch 2 times, most recently from 784f8a2 to dafc984 Compare November 20, 2024 12:33
@fmeum fmeum marked this pull request as ready for review November 20, 2024 12:41
@fmeum fmeum requested review from a team as code owners November 20, 2024 12:41
@fmeum fmeum requested review from gregestren and hvadehra and removed request for a team and gregestren November 20, 2024 12:41
@github-actions github-actions bot added team-Configurability platforms, toolchains, cquery, select(), config transitions team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. team-Rules-Java Issues for Java rules team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Nov 20, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Nov 20, 2024

@hvadehra Had to fix one more test, CI is green now.

@hvadehra hvadehra added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally labels Nov 21, 2024
@hvadehra
Copy link
Member

@fmeum resolve conflicts please?

@fmeum fmeum force-pushed the drop-java-runfiles-library branch from c90618f to e1703a0 Compare November 21, 2024 13:21
@fmeum fmeum requested a review from hvadehra November 21, 2024 13:21
@hvadehra
Copy link
Member

As it turns out, this is not so easy to import. There is a divergence between the internal BUILD files and one's being changed here.

Also the (deleted) files are still used internally, and simply pointing them to the internal rules_java copy doesn't work since we made those bazel only. Changing the latter is going to involve some complex copybara, at the very least for the tests.

@meteorcloudy Thoughts?

@fmeum
Copy link
Collaborator Author

fmeum commented Nov 21, 2024

@comius who also mentioned a complex import for the c++ lib.

@meteorcloudy
Copy link
Member

Hmm, eventually we do want to use the runfiles library from rules_java both internally and externally, right? If this is not going to make it for Bazel 8, we should probably spend some time on untangling the copybara setup?

@hvadehra hvadehra self-assigned this Nov 26, 2024
@hvadehra hvadehra removed team-Configurability platforms, toolchains, cquery, select(), config transitions team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. team-Remote-Exec Issues and PRs for the Execution (Remote) team labels Nov 26, 2024
copybara-service bot pushed a commit to bazelbuild/rules_java that referenced this pull request Nov 26, 2024
@hvadehra
Rename rules_java runfiles package BUILD.bazel -> BUILD
6b37b15 
Work towards bazelbuild/bazel#24394

PiperOrigin-RevId: 700322638
Change-Id: Ic8af8b0bb8ad82f0e89c87b3ccb84d44b89067c5
copybara-service bot pushed a commit to bazelbuild/intellij that referenced this pull request Nov 26, 2024
@copybara-github
Simplify java runfiles library usage in tests
becca7d 
Work towards bazelbuild/bazel#24394

PiperOrigin-RevId: 700325236
@copybara-service copybara-service bot mentioned this pull request Nov 26, 2024
Merged
copybara-service bot pushed a commit to bazelbuild/intellij that referenced this pull request Nov 27, 2024
@copybara-github
Simplify java runfiles library usage in tests
7e367d1 
Work towards bazelbuild/bazel#24394

PiperOrigin-RevId: 700325236
copybara-service bot pushed a commit to bazelbuild/intellij that referenced this pull request Nov 27, 2024
@copybara-github
Simplify java runfiles library usage in tests
ff36e0e 
Work towards bazelbuild/bazel#24394

PiperOrigin-RevId: 700586193
copybara-service bot pushed a commit that referenced this pull request Nov 27, 2024
@hvadehra @copybara-github
Update BUILD files in tools/java/runfiles
6884e82 
Work towards #24394

PiperOrigin-RevId: 700624807
Change-Id: Iaca87f49b1fdad090ef00eef0828f60ca30f4e55
copybara-service bot pushed a commit that referenced this pull request Nov 27, 2024
@hvadehra @copybara-github
Migrate usages of java runfiles lib from @bazel_tools to @rules_java
26fd07e 
Work towards #24394

PiperOrigin-RevId: 700652158
Change-Id: I94709ef8cee7ce358ff1e13430ebe33d0be7b249
@fmeum fmeum deleted the drop-java-runfiles-library branch November 28, 2024 15:05
@fmeum
Copy link
Collaborator Author

fmeum commented Nov 28, 2024

@bazel-io flag

@fmeum
Copy link
Collaborator Author

fmeum commented Nov 28, 2024

(for 8.1.0)

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Nov 28, 2024
@iancha1992
Copy link
Member

@bazel-io fork 8.1.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Dec 10, 2024
@bazel-io bazel-io mentioned this pull request Dec 10, 2024
Open
@BoleynSu
Copy link
Contributor

BoleynSu commented Dec 21, 2024 •
edited
Loading

It is off topic, but can we also kill JAVA_RUNFILES during the process? There is a TODO to kill it but nobody did it yet.

@fmeum
Copy link
Collaborator Author

fmeum commented Dec 22, 2024

It is off topic, but can we also kill JAVA_RUNFILES during the process? There is a TODO to kill it but nobody did it yet.

Yes, we should, but that affects all runfiles libraries as well as Bazel itself. I would say that getting rid of RUNFILES_MANIFEST_ONLY has higher priority though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvadehra hvadehra Awaiting requested review from hvadehra

Assignees

@hvadehra hvadehra

Labels
team-Rules-Java Issues for Java rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fmeum @hvadehra @meteorcloudy @iancha1992 @BoleynSu @bazel-io