Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non-standard lib dependencies #3

Closed
banesullivan opened this issue Jun 25, 2019 · 1 comment
Closed

non-standard lib dependencies #3

banesullivan opened this issue Jun 25, 2019 · 1 comment

Comments

@banesullivan
Copy link
Owner

Should we allow non-standard lib dependencies like psutil which I just added?

I think it's rather important to report the total amount of RAM and psutil has a solution that works for all OS - which I'm not sure how to implement without psutil.

Also, we will definitely need GPU details for PyVista as #1 requests which I think will have to depend on more than one external lib for inspecting the different types of GPUs that could be present (NVIDIA, Radeon, etc.)

Perhaps these should be optional requirements so that this could remain a lightweight package for users that do not need RAM or GPU details?
@banesullivan
Copy link
Owner Author

I made psutil an extra dependency and plan to implement any GPU inspection the same way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@banesullivan