Allow for update (PATCH) of group's name

[sripwoud]

Is your feature request related to a problem? Please describe.
Right now it is not allowed to update the name of a group via PATCH /groups/{group}.

curl -X 'PATCH' \
  'https://api.bandada.pse.dev/groups/<redacted>' \
  -H 'accept: application/json' \
  -H 'x-api-key: <redacted>' \
  -H 'Content-Type: application/json' \
  -d '{
  "name": "new name"
}'

gives

{
  "statusCode": 400,
  "message": [
    "property name should not exist"
  ],
  "error": "Bad Request"
}

Indeed update-group.dto.ts does not include name

Describe the solution you'd like
I'd like the RESTAPI and SDK to allow updating the name

Describe alternatives you've considered
Deleting the existing group and recreating a new one with the new desired name, adding back all members.

[Iwueseiter]

Hi @sripwoud please can I work on this?

[sripwoud]

@Iwueseiter I'd say go ahead. But I am not admin/maintainer of this repo though: @vplasencia ?
(maybe I am lacking context, and there is/was a reason to not allow updating the group's name?)

[vplasencia]

Hey @sripwoud! Thank you very much for creating the issue. It should be solved by adding the group name to the update-group.dto.ts

[vplasencia]

Hey @Iwueseiter yes, you can work on it. Do you want me to assign you the issue?

[Iwueseiter]

Hey @Iwueseiter yes, you can work on it. Do you want me to assign you the issue?

yes please I'm ready to work.

[vplasencia]

Hey @Iwueseiter! I just assigned the issue to you. Please, let us know if you have any questions.

[Iwueseiter]

Hey @Iwueseiter! I just assigned the issue to you. Please, let us know if you have any questions.

Alright🚀

[vplasencia]

Hey @sripwoud and @Iwueseiter!

It's not possible to update the group name right now because the group id is created using the name. I think we would need to find a different way to generate the group id first.

[sripwoud]

Hey @sripwoud and @Iwueseiter!

It's not possible to update the group name right now because the group id is created using the name. I think we would need to find a different way to generate the group id first.

I created #593