Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Drivelist incompatible with new V8 engines (V8 > 8.3) #379

Open
bennymeg opened this issue Nov 26, 2020 · 4 comments
Open

[Bug] Drivelist incompatible with new V8 engines (V8 > 8.3) #379

bennymeg opened this issue Nov 26, 2020 · 4 comments

Comments

@bennymeg
Copy link

bennymeg commented Nov 26, 2020

Drivelist incompatible with Electron 10+ (latest compatible version: Electron 9).

failed to recompile or throwing the following error:

Module did not self-register: '\\?\C:\Users\FelixDocuments\Code\Keynote\node_modules\drivelist\build\Release\drivelist.node'.
    at process.func [as dlopen] (electron/js2c/asar.js:140:31) 
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:1196:18)
    at Object.func [as .node] (electron/js2c/asar.js:140:31)   
    at Module.load (internal/modules/cjs/loader.js:981:32)     
    at Module._load (internal/modules/cjs/loader.js:881:14)    
    at Function.Module._load (electron/js2c/asar.js:779:28)    
    at Module.require (internal/modules/cjs/loader.js:1023:19) 
    at require (internal/modules/cjs/helpers.js:77:18)
    at bindings (C:\Users\FelixDocuments\Code\Keynote\node_modules\bindings\bindings.js:112:48)
    at Object.<anonymous> (C:\Users\FelixDocuments\Code\Keynote\node_modules\drivelist\js\index.js:25:27)    
@shmulka
Copy link

shmulka commented Jan 5, 2021

Drivelist fails to recompile for Electron 10 /11 Windows - using Window build tools 2015.
Using Window build tools 2017, recompile 'succeeds' but with warnings (MSB8029, MSB8012, C4996, C4309).
Best solution moving forward would be to insulate from changes in the underlying JavaScript engine by migrating from NAN to N-API.

@bennymeg bennymeg changed the title [Feature] Electron 10/11 support [Bug] Drivelist incompatible with new V8 engines (V8 > 8.3) Nov 30, 2021
@bennymeg
Copy link
Author

Maybe #392 PR will had solved this issue?

@jfbvm
Copy link

jfbvm commented May 12, 2022

Any solution for this issue?

@bennymeg
Copy link
Author

bennymeg commented May 12, 2022

Well,
I've done some digging inside etcher, it seems that the are running electron v12 whilst using etcher-sdk (which requires drivelist). So I guess that it is somehow possible to use newer electron with some webpack magic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants