Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifacts with Japanese descriptions but no English descriptions #12

Open
backwardsEric opened this issue Feb 19, 2021 · 5 comments
Open
Labels
enhancement New feature or request

Comments

@backwardsEric
Copy link
Owner

backwardsEric commented Feb 19, 2021

These artifacts have Japanese descriptions but do not have English descriptions in both 2.2.1 and 3.0.0 (ones struck through have picked up descriptions since this issue was opened):

  • 'Hrunting'
  • of Arryu-Chien-Kun
  • of Mito Koumon
  • 'Tailbiter'
  • of Giles
  • 'Quickthorn'
  • 'Littlethorn'
  • 'Excalibur'
  • of halfheart
  • of idler
  • Falcon Sword of Destruction
  • 'Stormbringer'
  • 'Golden Hammer'
  • Dragonic Sword
  • 'Aegis Fang'
  • Bastard Sword of Eowyn
  • of Sacred Knights
  • Needle 'Plag'
@backwardsEric backwardsEric added the enhancement New feature or request label Feb 19, 2021
@backwardsEric
Copy link
Owner Author

A recent change adds two more to the list (apparently brought over from Xangband):

  • 'Icingdeath'
  • 'Twinkle'

@backwardsEric
Copy link
Owner Author

This pull request, hengband#401 , took care of the descriptions for 'Icingdeath' and 'Twinkle'.

@backwardsEric
Copy link
Owner Author

A recent change adds one more to the list, Longbow of Diana (from Nethack).

@backwardsEric
Copy link
Owner Author

Yasaka-no-Magatama also does not have an English description. It is present in 2.2.1 and 3.0.0. In 2.2.1 it does not have Japanese text, but it picked up Japanese text in April, 2021.

@backwardsEric
Copy link
Owner Author

backwardsEric commented Oct 21, 2024

The upstream pull request hengband#4469 (with corrections in 9ca5ebc ) adds English descriptions for Yasaka-no-Magatama, Hrunting, Tailbiter, of Giles, Quickthorn, Littlethorn, Excalibur, Falcon Sword of Destruction, and Bastard Sword of Eowyn. 012da00 ports those descriptions to the 2.2.1 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant