Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add getTopicAliasMaximum() to software.amazon.awssdk.crt.mqtt5.packets.ConnAckPacket #618

Closed
2 tasks
bgklika opened this issue May 9, 2023 · 2 comments · Fixed by #722
Closed
2 tasks
Labels
CRT/IoT feature-request A feature should be added or improved. p3 This is a minor priority issue

Comments

@bgklika
Copy link
Contributor

bgklika commented May 9, 2023

Describe the feature

At the moment class ConnAckPacket do not provide ability to read CONNACK topic alias maximum property (id 34 0x22).
I have tested another MQTT client on IoT Core and that property actually sent with value 8.

Please provide such method as well as parsing of 0x22 property from raw CONNACK data if missing.

Use Case

Any CRT or SDK-based MQTT client which topic alias feature.

Proposed Solution

Just add method and new Id in parser.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@bgklika bgklika added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 9, 2023
@bretambrose
Copy link
Contributor

Topic aliasing is supported in the native client (https://github.com/awslabs/aws-c-mqtt/blob/v0.8.11/include/aws/mqtt/v5/mqtt5_client.h#L61-L166) but we didn't bind it out on initial MQTT5 release. I can see about squeezing in some binding work sometime in the near future.

@bgklika
Copy link
Contributor Author

bgklika commented May 9, 2023

Hello Bret!

Please take on account for planning:

  1. It is not a urgent request
  2. request is only for topic alias maximum not for whole topic alias feature

@yasminetalby yasminetalby added p3 This is a minor priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Jun 26, 2023
@jmklix jmklix added the CRT/IoT label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CRT/IoT feature-request A feature should be added or improved. p3 This is a minor priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants