Failed to build on aarch64-apple-darwin

[thynson]

Problem:

s2n-quic repository failed to build on aarch64-apple-darwin (Apple macBook M1). Actually they are two development crates failed to build: ahash and aws-lc-sys

Noticed that #2118 pinned it to 0.8.7 to make it compiles on rust v1.71.1, however on aarch64-apple-darwin, I got the following compile error:

error[E0658]: use of unstable library feature 'stdsimd'
   --> /PATH/TO/SOMEWHERE/ahash-0.8.7/src/operations.rs:124:24
    |
124 |     let res = unsafe { vaesmcq_u8(vaeseq_u8(transmute!(value), transmute!(0u128))) };
    |                        ^^^^^^^^^^
    |
    = note: see issue #48556 <https://github.com/rust-lang/rust/issues/48556> for more information

error[E0658]: use of unstable library feature 'stdsimd'
   --> /PATH/TO/SOMEWHERE/ahash-0.8.7/src/operations.rs:154:24
    |
154 |     let res = unsafe { vaesimcq_u8(vaesdq_u8(transmute!(value), transmute!(0u128))) };
    |                        ^^^^^^^^^^^
    |
    = note: see issue #48556 <https://github.com/rust-lang/rust/issues/48556> for more information

And for building issue of aws-lc-sys, it's already tracked on aws/aws-lc-rs#342 and I left my error log there.

Solution:

1. ahash actually can be removed, it's not used actually, or change it to 0.8.6 if there is reason to keep it.

2. pin aws-lc-rs to ~1.5 and s2n-tls to =0.1.2, or do nothing and wait a fix for Fails to build on Apple Silicon M2 aws-lc-rs#342

[camshaft]

What version of rustc are you trying to use? Note that s2n-quic has only pinned ahash as part of our own dev-dependencies as to not restrict newer versions of rustc from taking the latest ahash builds. If you're wanting to compile on 1.71, you'll also need to pin ahash in your own crate, at least until rust-lang/cargo#9930 is solved,

As for the aws-lc-rs issue, we're waiting for aws/aws-lc-rs#349 to be released and the issue should resolve itself.

[thynson]

What version of rustc are you trying to use?

I'm trying to build the s2n-quic codebase, so the rust-toolchain file made it 1.71.1, as I'm trying to add client authentication support for s2n-quic-rustls.

And there is no building issue to use v1.33 as a dependency, So probably you don't want a new release for it.

[WesleyRosenblum]

The aws--lc-rs issue has been resolved, and we've now addressed the ahash issue (at least in building s2n-quic itself) by pinning it to 0.8.6 in #2127, though as mentioned you will need to pin it in your own application if you want to build with Rust 1.711. . Feel free to reopen if you experience further issues