Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add revisionHistoryLimit support to aws-for-fluent-bit values #1124

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add revisionHistoryLimit support to aws-for-fluent-bit values #1124

wants to merge 2 commits into from
+5 −1

Conversation

booleanbetrayal
Copy link

@booleanbetrayal booleanbetrayal commented Jun 18, 2024 •
edited
Loading

Issue

Lack of support for revisionHistoryLimit in aws-for-fluent-bit chart values / DaemonSet leads to potentially unnecessary / annoying clutter of revision sets.

Description of changes

Adds revisionHistoryLimit support in aws-for-fluent-bit with defaults set to K8s default, following the lead in aws-load-balancer-controller.

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

helm template validation

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

PettitWesley
PettitWesley previously approved these changes Jun 19, 2024
View reviewed changes
@booleanbetrayal
Copy link
Author

Thanks for the review @PettitWesley !

@booleanbetrayal
Copy link
Author

Just checking on what the merge criteria is now that this has been approved. Looking forward to de-cluttering!

@bryantbiggs bryantbiggs mentioned this pull request Oct 3, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PettitWesley PettitWesley PettitWesley approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@booleanbetrayal @PettitWesley