Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove paragonie/random_compat dev dependency #3020

Open
2 tasks
TimWolla opened this issue Nov 4, 2024 · 2 comments
Open
2 tasks

Remove paragonie/random_compat dev dependency #3020

TimWolla opened this issue Nov 4, 2024 · 2 comments
Assignees
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue

Comments

@TimWolla
Copy link

TimWolla commented Nov 4, 2024

Describe the feature

Remove the paragonie/random_compat dev dependency, because it is unnecessary, given the fact that the AWS SDK requires PHP 7.2. PHP 7.0+ guarantees the existence of the CSPRNG.

Use Case

Clean up the list of dependencies and reduce unnecessary network traffic.

Proposed Solution

This line should be removed:

"paragonie/random_compat": ">= 2",

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

SDK version used

git master

Environment details (Version of PHP (php -v)? OS name and version, etc.)

n/a

@TimWolla TimWolla added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 4, 2024
@stobrien89
Copy link
Member

Hi @TimWolla,

Thanks for pointing this out. Happy to accept a PR for this if you want to open one. We'll open one in a couple of days if we don't hear back.

@stobrien89 stobrien89 added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed needs-triage This issue or PR still needs to be triaged. labels Nov 8, 2024
@stobrien89 stobrien89 self-assigned this Nov 8, 2024
@TimWolla
Copy link
Author

TimWolla commented Nov 8, 2024

Happy to accept a PR for this if you want to open one.

I'm afraid I can't: https://github.com/aws/.github/blob/5f97540a10eaac583000a6cb54ce4de9e3840a8a/PULL_REQUEST_TEMPLATE#L6 does not give any exception for trivial changes and I would need to run this through company legal.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Nov 9, 2024
@RanVaknin RanVaknin added the p2 This is a standard priority issue label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

3 participants