From e57a05f865022e353e338acc00f778dd329e74b4 Mon Sep 17 00:00:00 2001 From: Kaizen Conroy <36202692+kaizencc@users.noreply.github.com> Date: Mon, 23 Dec 2024 09:52:04 -0500 Subject: [PATCH] Apply suggestions from code review --- .../toolkit/lib/cloud-assembly-source.ts | 3 +-- packages/@aws-cdk/toolkit/lib/io-host.ts | 16 ++++++++-------- packages/@aws-cdk/toolkit/lib/types.ts | 2 +- 3 files changed, 10 insertions(+), 11 deletions(-) diff --git a/packages/@aws-cdk/toolkit/lib/cloud-assembly-source.ts b/packages/@aws-cdk/toolkit/lib/cloud-assembly-source.ts index dff67e4ce4aca..5973d0cc144e1 100644 --- a/packages/@aws-cdk/toolkit/lib/cloud-assembly-source.ts +++ b/packages/@aws-cdk/toolkit/lib/cloud-assembly-source.ts @@ -30,7 +30,6 @@ export interface CdkAppDirectoryProps { } export class CloudAssemblySource implements ICloudAssemblySource { - /** * Use a directory containing an AWS CDK app as source. * @param directory the directory of the AWS CDK app. Defaults to the current working directory. @@ -50,7 +49,7 @@ export class CloudAssemblySource implements ICloudAssemblySource { } /** - * A CloudAssemblySource that is caching it's result once produced. + * A CloudAssemblySource that is caching its result once produced. * * Most Toolkit interactions should use a cached source. * Not caching is relevant when the source changes frequently diff --git a/packages/@aws-cdk/toolkit/lib/io-host.ts b/packages/@aws-cdk/toolkit/lib/io-host.ts index 95c8cb3e632b4..7038bf89138a2 100644 --- a/packages/@aws-cdk/toolkit/lib/io-host.ts +++ b/packages/@aws-cdk/toolkit/lib/io-host.ts @@ -15,16 +15,16 @@ export interface IoRequest extends IoMessage { export interface IIoHost { /** - * Notifies the host of a message. - * The caller waits until the notification completes. - */ + * Notifies the host of a message. + * The caller waits until the notification completes. + */ notify(msg: IoMessage): Promise; /** - * Notifies the host of a message that requires a response. - * - * If the host does not return a response the suggested - * default response from the input message will be used. - */ + * Notifies the host of a message that requires a response. + * + * If the host does not return a response the suggested + * default response from the input message will be used. + */ requestResponse(msg: IoRequest): Promise; } diff --git a/packages/@aws-cdk/toolkit/lib/types.ts b/packages/@aws-cdk/toolkit/lib/types.ts index d693a6c22c1f1..267ac9ecae88d 100644 --- a/packages/@aws-cdk/toolkit/lib/types.ts +++ b/packages/@aws-cdk/toolkit/lib/types.ts @@ -22,7 +22,7 @@ export enum StackSelectionStrategy { /** * Throws an exception if the app doesn't contain at least one stack. */ - AtLeastOne = 'at-lest-one', + AtLeastOne = 'at-least-one', /** * Returns all stacks in the main (top level) assembly only.