Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate historical proofs in eth_getProof API. #714

Open
darioush opened this issue Dec 20, 2024 · 0 comments
Open

Deprecate historical proofs in eth_getProof API. #714

darioush opened this issue Dec 20, 2024 · 0 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@darioush
Copy link
Collaborator

  • Add a boolean VM configuration option like historical-proofs which defaults to false.
  • In the API layer, reject calls to eth_getProof for blocks before latest - tipBufferSize, this is because with a path based trie, there is no good way to recall historical trie nodes and storing these nodes is a burden for validators. For most use cases (eg, message passing) it should suffice to verify state near the head of the chain, as often these use cases are time-sensitive.

Additional considerations / discussion topics:

  • Entities with an interest in maintaining historical proofs can maintain their own indexes or use the hash db and modify the config option from its default.
  • We can make the config option an integer which also controls tipBufferSize, which will also need to match the in-memory layers we keep at tip for the pathdb.
  • Should we consider an upstream PR?
@darioush darioush added the good first issue Good for newcomers label Dec 20, 2024
@qdm12 qdm12 self-assigned this Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants