Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigation(params/extras): do we need ChainConfig nil checks in method calls? #712

Open
qdm12 opened this issue Dec 19, 2024 · 0 comments
Labels
after coreth x subnet-evm To be done after merging the coreth and subnet-evm codebases cleanup

Comments

@qdm12
Copy link
Collaborator

qdm12 commented Dec 19, 2024

Some of the ChainConfig methods have a nil check on the receiving object, for example:

if c == nil {
return nil
}

Whilst some other methods don't.
Should we require these everywhere or remove them everywhere? I would lean on removing them to let the caller do the nil check, to avoid silently having funny results.

@qdm12 qdm12 added cleanup after coreth x subnet-evm To be done after merging the coreth and subnet-evm codebases labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
after coreth x subnet-evm To be done after merging the coreth and subnet-evm codebases cleanup
Projects
None yet
Development

No branches or pull requests

1 participant